Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use full manifest in adapter instead of macro_manifest #10609

Merged
merged 5 commits into from
Aug 29, 2024
Merged

use full manifest in adapter instead of macro_manifest #10609

merged 5 commits into from
Aug 29, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Aug 26, 2024 •
edited by peterallenwebb
Loading

Resolves #10599

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner August 26, 2024 20:09
@cla-bot cla-bot bot added the cla:yes label Aug 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov Codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (98fddcf) to head (0bc31c6).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10609      +/-   ##
==========================================
+ Coverage   88.89%   88.92%   +0.02%     
==========================================
  Files         180      180              
  Lines       22779    22778       -1     
==========================================
+ Hits        20250    20255       +5     
+ Misses       2529     2523       -6
Flag Coverage Δ
integration 86.24% <100.00%> (+0.10%) ⬆️
unit 62.35% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.35% <0.00%> (+<0.01%) ⬆️
Integration Tests 86.24% <100.00%> (+0.10%) ⬆️

@peterallenwebb peterallenwebb merged commit 9b7f4ff into main Aug 29, 2024
65 of 66 checks passed
@peterallenwebb peterallenwebb deleted the check_for_macro_manifest branch August 29, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterallenwebb peterallenwebb peterallenwebb approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The env_var Function Cannot Be Ued in the create_schema Macro
2 participants
@gshank @peterallenwebb